Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(produce): support message compression #608

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

shenhui0509
Copy link
Contributor

What is the purpose of the change

Support message compression

Brief changelog

add message compress feature for producer

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@shenhui0509 shenhui0509 changed the title fit(produce): support message compression feat(produce): support message compression Feb 11, 2021
@duhenglucky duhenglucky requested review from xujianhai666 and wenfengwang and removed request for xujianhai666 February 18, 2021 06:29
@duhenglucky duhenglucky added the enhancement New feature or request label Feb 18, 2021
@ShannonDing
Copy link
Member

消息体被压缩后发送,如果失败, 尝试重试发送的时候,会不会出现消息体重复压缩?

@shenhui0509
Copy link
Contributor Author

消息体被压缩后发送,如果失败, 尝试重试发送的时候,会不会出现消息体重复压缩?

确实有可能,我加一个flag标记下

@codecov-io
Copy link

codecov-io commented Feb 28, 2021

Codecov Report

Merging #608 (776ad21) into master (7e36c75) will increase coverage by 0.27%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
+ Coverage   24.29%   24.57%   +0.27%     
==========================================
  Files          48       48              
  Lines        5025     5074      +49     
==========================================
+ Hits         1221     1247      +26     
- Misses       3604     3621      +17     
- Partials      200      206       +6     
Impacted Files Coverage Δ
internal/utils/net.go 37.50% <0.00%> (-2.50%) ⬇️
primitive/message.go 23.92% <0.00%> (-0.12%) ⬇️
producer/producer.go 26.66% <14.28%> (-0.58%) ⬇️
producer/option.go 37.77% <66.66%> (-0.69%) ⬇️
internal/utils/compression.go 72.22% <78.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e36c75...776ad21. Read the comment docs.

@ShannonDing ShannonDing merged commit f5c1f61 into apache:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants