Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #869] Fix: Consumer api comments #867

Merged
merged 1 commit into from
Jul 25, 2022
Merged

[ISSUE #869] Fix: Consumer api comments #867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ func NewTransactionProducer(listener primitive.TransactionListener, opts ...prod
}

type PushConsumer interface {
// Start the PullConsumer for consuming message
// Start the PushConsumer for consuming message
Start() error

// Shutdown the PullConsumer, all offset of MessageQueue will be sync to broker before process exit
// Shutdown the PushConsumer, all offset of MessageQueue will be sync to broker before process exit
Shutdown() error
// Subscribe a topic for consuming
Subscribe(topic string, selector consumer.MessageSelector,
Expand Down