csharp: Add using to wrap HMACSHA1 instance (#582)

* csharp: Add using for HMACSHA1 Signed-off-by: catcherwong <catcher_hwq@outlook.com> * fix dotnet-format error Signed-off-by: catcherwong <catcher_hwq@outlook.com> --------- Signed-off-by: catcherwong <catcher_hwq@outlook.com>
apache · Aug 4, 2023 · 01deef8 · 01deef8
1 parent 1e7aa33
commit 01deef8
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/csharp/rocketmq-client-csharp/Signature.cs b/csharp/rocketmq-client-csharp/Signature.cs
@@ -59,15 +59,17 @@ public static Dictionary<string, string> Sign(Client client)
 
  var secretData = Encoding.ASCII.GetBytes(credentials.AccessSecret);
  var data = Encoding.ASCII.GetBytes(time);
- var signer = new HMACSHA1(secretData);
- var digest = signer.ComputeHash(data);
- var hmac = BitConverter.ToString(digest).Replace("-", "");
- var authorization = $"{MetadataConstants.AlgorithmKey} " +
- $"{MetadataConstants.CredentialKey}={credentials.AccessKey}, " +
- $"{MetadataConstants.SignedHeadersKey}={MetadataConstants.DateTimeKey}, " +
- $"{MetadataConstants.SignatureKey}={hmac}";
- dictionary.Add(MetadataConstants.Authorization, authorization);
- return dictionary;
+ using (var signer = new HMACSHA1(secretData))
+ {
+ var digest = signer.ComputeHash(data);
+ var hmac = BitConverter.ToString(digest).Replace("-", "");
+ var authorization = $"{MetadataConstants.AlgorithmKey} " +
+ $"{MetadataConstants.CredentialKey}={credentials.AccessKey}, " +
+ $"{MetadataConstants.SignedHeadersKey}={MetadataConstants.DateTimeKey}, " +
+ $"{MetadataConstants.SignatureKey}={hmac}";
+ dictionary.Add(MetadataConstants.Authorization, authorization);
+ return dictionary;
+ }
  }
  }
 }