Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to turn off SSL into the example code to avoid some compatibility issues #552

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

aaron-ai
Copy link
Member

Which Issue(s) This PR Fixes

Fixes #551

Brief Description

Add comments to turn off SSL into the example code to avoid some compatibility issues.

How Did You Test This Change?

Just add comments, no need more testings.

xdkxlk
xdkxlk previously approved these changes Jun 26, 2023
Copy link

@xdkxlk xdkxlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #552 (0c4501f) into master (f1d5e95) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #552   +/-   ##
=========================================
  Coverage     45.98%   45.98%           
  Complexity      667      667           
=========================================
  Files           207      207           
  Lines         11503    11503           
  Branches       2933     2933           
=========================================
  Hits           5290     5290           
  Misses         5983     5983           
  Partials        230      230           
Flag Coverage Δ
java 62.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@xdkxlk xdkxlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaron-ai aaron-ai merged commit 5386144 into apache:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add comments to turn off SSL into the example code to avoid some compatibility issues.
3 participants