fix(rust): change sequence number type of message id from i16 to i32 #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SSpirits <admin@lv5.moe>
ShadowySpirits
force-pushed
the
fix_message_id
branch
from
dc813b2
to
ec7995d
Compare
Signed-off-by: SSpirits <admin@lv5.moe>
Signed-off-by: SSpirits <admin@lv5.moe>
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
============================================
- Coverage 46.84% 46.78% -0.06%
Complexity 667 667
============================================
Files 208 208
Lines 11889 11889
Branches 3319 3319
============================================
- Hits 5569 5562 -7
- Misses 6075 6082 +7
Partials 245 245
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhouxinyu
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sequence number of message id should be 4 bytes/32-bit. But the current implementation in rust client is 2 bytes/16-bit, this pr fixes it.