Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Simple Consumer for Python Client #588

Merged
merged 8 commits into from
Aug 26, 2023

Conversation

yanchaomei
Copy link
Contributor

Brief Description

implement simple consumer for python client
now it can start first, and then receive message, finally it can send ack to server.

How Did You Test This Change?

use test function in simple_consumer.py to test the simple consumer

@yanchaomei yanchaomei changed the title Implement of Simple Consumer for Python Client Implementation of Simple Consumer for Python Client Aug 23, 2023
Copy link
Member

@aaron-ai aaron-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide more tests for the consumer part?

python/rocketmq/simple_consumer.py Outdated Show resolved Hide resolved
python/rocketmq/simple_consumer.py Show resolved Hide resolved
@yanchaomei
Copy link
Contributor Author

Could you provide more tests for the consumer part?

Right, I add test_fifo_message, test_change_invisible_duration and test_subscribe_unsubscribe for the simple consumer

Copy link
Member

@aaron-ai aaron-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aaron-ai aaron-ai merged commit d450648 into apache:master Aug 26, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants