Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #220] Add unit test(controller module) #236

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

Oliverwqcwrw
Copy link
Member

What is the purpose of the change

Follow #220

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@Oliverwqcwrw
Copy link
Member Author

reflections of 0.9.12 has a bug, so i change the version to 0.9.11
reference [ISSUE #273]
@odbozhou @sunxiaojian

@Oliverwqcwrw Oliverwqcwrw changed the title [ISSUE #220] Add controller module unit test [ISSUE #220] Add unit test(controller module) Aug 4, 2022
@sunxiaojian
Copy link
Contributor

reflections of 0.9.12 has a bug, so i change the version to 0.9.11 reference [ISSUE #273] @odbozhou @sunxiaojian

ISSUE was proposed in 2020. Has the latest version 0.10.2 solved this problem?

@sunxiaojian
Copy link
Contributor

reflections of 0.9.12 has a bug, so i change the version to 0.9.11 reference [ISSUE #273] @odbozhou @sunxiaojian

image
0.10 fixed

@Oliverwqcwrw
Copy link
Member Author

Thanks for your reply @sunxiaojian
Ok, I will upgrade to 0.10.2

@odbozhou
Copy link
Contributor

please handle the conflict

@Oliverwqcwrw
Copy link
Member Author

please handle the conflict

done

@odbozhou odbozhou merged commit ddc334b into apache:master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants