Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add topic message type #179

Merged
merged 1 commit into from
Jun 4, 2024
Merged

feat: add topic message type #179

merged 1 commit into from
Jun 4, 2024

Conversation

guangdashao
Copy link
Contributor

@guangdashao guangdashao commented Jul 27, 2023

What is the purpose of the change

add message type when topic create or change

add transaction message send
#5538 - issue reported for examine Topic Config Query not returning message.type in query result.

Brief changelog

1。in topic page , when create or change topic ,add message type
2. in topic page ,when send message test , add transaction message producer to send message

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

add message type
@iamgd67
Copy link

iamgd67 commented Aug 2, 2023

nice

@iamgd67
Copy link

iamgd67 commented Nov 21, 2023

@lizhanhui please review this, this is very useful feacher.

@RongtongJin RongtongJin merged commit 823bce2 into apache:master Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants