-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #58] enable the service to support multiple namesrvs #59
Conversation
1 failing check, pls check it. Failed tests: |
OK. I will fix it. |
|
||
public void setNamesrvAddrs(String namesrvAddrs) { | ||
this.namesrvAddrs = namesrvAddrs; | ||
List<String> nameSrvAddrList = Splitter.on(";").splitToList(this.namesrvAddrs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If multiple namesrv services are deployed in a rocketmq cluster, namesrv addresses are connected using ';' by default. So there is a problem If ';' are used to divide multiple rocketmq clusters in here, it cannot distinguish between two namesrv addresses belonging to the same rocketmq cluster or to different rocketmq clusters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, we don't need to distinguish whether namesrvs belong to the same cluster. Because if two namesrv points to the same cluster, we only need to choose one of them to work, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhangjidi2016 However, we can also use @
to distinguish the namesrv of different clusters, just like this:
rocketmq.config.namesrvAddrs=localhost1:9876;localhost2:9876@localhost3:9876;localhost4:9876
I will fix it. :-D
What is the purpose of the change
#58
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.