feat: Adapted to RocketMQ 5.x docker compose #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leizhiyuan
reviewed
Feb 21, 2024
|
|
||
|
|
||
| if [[ "${version}" > "5.0.0" ]]; then |
There was a problem hiding this comment.
rmq5 也可以不使用 proxy，单独部署broker。这里后续相当于只要5.x以上的，docker compose。就有proxy对吧。用户根据自己的需求，连接proxy/ns 来实现不同的case
leizhiyuan
reviewed
Feb 21, 2024
leizhiyuan
suggested changes
Feb 21, 2024
zzjcool
force-pushed
the
feat/rmq5-docker
branch
from
fb61ec3
to
9e7e664
Compare
zzjcool
force-pushed
the
feat/rmq5-docker
branch
from
9e7e664
to
bac812e
Compare
Linux 环境运行5.2.0版本 |
mac run 5.1.3 |
leizhiyuan
reviewed
Feb 21, 2024
| @@ -46,9 +46,18 @@ fi | |||
| echo "mkdir $STAGE_DIR/$version" | |||
| mkdir -p "$STAGE_DIR/$version" | |||
|
|
|||
| cp -rf "$CURRENT_DIR/templates/" "$STAGE_DIR/$version" | |||
| cp -rf "$CURRENT_DIR/templates" "$STAGE_DIR/$version" | |||
There was a problem hiding this comment.
这行会兼容mac和linux的cp命令，可以解决readme中提到的手动处理的问题。
lizhanhui
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted to RocketMQ 5.x docker compose
issue: #100