Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish according to Prometheus rules #1

Open
vongosling opened this issue Jun 10, 2019 · 0 comments
Open

Polish according to Prometheus rules #1

vongosling opened this issue Jun 10, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@vongosling
Copy link
Member

vongosling commented Jun 10, 2019

If possible use counters rather than gauges.

rocketmq_producer_put_size is missing units, and as a counter should end in _total.

rocketmq_group_get_latency is missing a unit and should be a Summary without quantiles if possible.

cluster and broker sound like target labels, which should come from Prometheus rather than the exporter.

Your port number isn't in the usual range from the wiki page.

More details see https://prometheus.io/docs/instrumenting/writing_exporters/

@vongosling vongosling added the enhancement New feature or request label Jun 10, 2019
@vongosling vongosling added this to the 0.0.1 milestone Jun 10, 2019
@vongosling vongosling changed the title Polish for the exporter according to Prometheus rules Polish according to Prometheus rules Jun 14, 2019
vongosling added a commit that referenced this issue Jul 5, 2019
[ISSUE #1]Add grafana dashboard for rocketmq exporter and Modify some metrics
hdchen pushed a commit that referenced this issue May 21, 2020
merge the change of master branch
francisoliverlee pushed a commit that referenced this issue Dec 8, 2020
@vongosling vongosling modified the milestones: 0.0.1, 0.0.2 Jan 6, 2022
@vongosling vongosling pinned this issue Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant