Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #91] remove lastupdateTimestamp for offset metric #102

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

cserwen
Copy link
Member

@cserwen cserwen commented May 17, 2022

What is the purpose of the change

Fix #91

Brief changelog

lastUpdateTimestamp should not be put into lables.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #102 (4269107) into master (8bc34bc) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##             master    #102   +/-   ##
========================================
  Coverage      0.35%   0.35%           
  Complexity        2       2           
========================================
  Files            30      30           
  Lines          2242    2240    -2     
  Branches        195     195           
========================================
  Hits              8       8           
+ Misses         2234    2232    -2     
Impacted Files Coverage Δ
...cketmq/exporter/collector/RMQMetricsCollector.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bc34bc...4269107. Read the comment docs.

@ShannonDing ShannonDing added the bug Something isn't working label Jul 31, 2022
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit e19e65a into apache:master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cached metric cause bug.
3 participants