Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the comment of maxReconsumeTimes. #378

Closed
heihaozi opened this issue Jun 29, 2021 · 0 comments · Fixed by #379
Closed

Improve the comment of maxReconsumeTimes. #378

heihaozi opened this issue Jun 29, 2021 · 0 comments · Fixed by #379

Comments

@heihaozi
Copy link
Contributor

In different consumption modes, the meaning of maxReconsumeTimes being -1 is not the same.

In concurrently mode, -1 means 16. In orderly mode, -1 means Integer.MAX_VALUE.

It can give users or source code readers better guidance.
@heihaozi heihaozi mentioned this issue Jun 29, 2021
Merged
5 tasks
@maixiaohai maixiaohai linked a pull request Jul 13, 2021 that will close this issue
[ISSUE #378]Improve the comment of maxReconsumeTimes #379
Merged
5 tasks
wenfengwang added a commit that referenced this issue Jul 16, 2021
@wenfengwang
Merge pull request #379 from heihaozi/maxReconsumeTimes
6185423 
[ISSUE #378]Improve the comment of maxReconsumeTimes
@dependabot dependabot bot mentioned this issue Oct 20, 2022
Closed
@github-actions github-actions bot mentioned this issue Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #378]Improve the comment of maxReconsumeTimes heihaozi/rocketmq-spring
1 participant
@heihaozi