Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #317]move spring.factories file to rocketmq-spring-boot-starter #318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jerrymice
Copy link

@jerrymice jerrymice commented Nov 26, 2020

What is the purpose of the change

When Only dependent rocketmq-spring-boot not rocketmq-spring-boot-starter, RocketMQAutoConfiguration The class will also be injected into the spring container, This is not supposed to happen,This will affect developer custom AutoConfiguration class, More content Spring-Boot open source project specification.

Brief changelog

move spring.factories file from rocketmq-spring-boot to rocketmq-spring-boot-starter

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exists.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

…rter, RocketMQAutoConfiguration The class will also be injected into the spring container, This is not supposed to happen, move rocketmq-spring-boot-starter,

move spring.factories from rocketmq-spring-boot to rocketmq-spring-boot-starter,
@vongosling
Copy link
Member

  1. Starter is the only one recommended entrance. 2. Before you make a merge request, you should mark the required items right in the checklist.

@jerrymice jerrymice changed the title When Only dependent rocketmq-spring-boot not rocketmq-spring-boot-sta… [ISSUE #317]move spring.factories to rocket-spring-boot-starter Nov 27, 2020
@jerrymice jerrymice changed the title [ISSUE #317]move spring.factories to rocket-spring-boot-starter [ISSUE #317]move spring.factories file to rocketmq-spring-boot-starter Nov 27, 2020
@vongosling vongosling added the discuss Discuss whether to support label Dec 10, 2020
@jerrymice
Copy link
Author

I agree 'Starter is the only one recommended entrance', but this is only suitable for ordinary users, In many Spring Boot open source projects, spring.factories file are placed in xx-Spring-boot-starter. Instead of xxX-spring-boot. This is more user-friendly for secondary development. If I want to develop a custom xxX-RocketMQ-Spring-boot-starter extension component, In other open source projects, I can rely only on XXX-Spring-boot instead of XXX-Spring-boot-starter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Discuss whether to support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants