Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #686] feat:Modify the inner class call to use the bean instance invocation #687

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WhyStart
Copy link

@WhyStart WhyStart commented Oct 9, 2024

What is the purpose of the change

fix #686

Brief changelog

Modify the inner class to call handleMessage as a bean invocation, so that the AOP interception of the handleMessage method can work properly.

Verifying this change

@Aspect
@Component
public class RocketMQMessageAspect {

	@Pointcut("execution(* org.apache.rocketmq.spring.support.DefaultRocketMQListenerContainer.handleMessage*(..))")
	public void rocketMQConsumerMethod() {}

	@Around("rocketMQConsumerMethod()")
	public Object logConsumerMethod(ProceedingJoinPoint joinPoint) throws Throwable {
		Object[] args = joinPoint.getArgs();
		MessageExt messageExt = (MessageExt) args[0];
                 // do something
		return joinPoint.proceed();
	}
}

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@WhyStart WhyStart changed the title feat:Modify the inner class call to use the bean instance invocation [ISSUE #123] feat:Modify the inner class call to use the bean instance invocation Oct 11, 2024
@WhyStart WhyStart changed the title [ISSUE #123] feat:Modify the inner class call to use the bean instance invocation [ISSUE #686] feat:Modify the inner class call to use the bean instance invocation Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat:Modify the inner class to call the handleMessage method using a bean approach
1 participant