Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] missing brokerName in sendMessageBack request #8584

Closed
3 tasks done
yuz10 opened this issue Aug 27, 2024 · 0 comments · Fixed by #8585
Closed
3 tasks done

[Bug] missing brokerName in sendMessageBack request #8584

yuz10 opened this issue Aug 27, 2024 · 0 comments · Fixed by #8585

Comments

@yuz10
Copy link
Member

yuz10 commented Aug 27, 2024

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Ubuntu 24.04

RocketMQ version

5.3.0

JDK Version

1.8

Describe the Bug

issue #3905 adds brokerName in remoting protocol, but in sendMessageBack request, the brokerName is missing.

when request proxy, and the broker address is not available in network, the consumer cannot send message back.

Steps to Reproduce

start a consumer that returns RECONSUME_LATER

        DefaultMQPushConsumer consumer = new DefaultMQPushConsumer("group");

        consumer.setNamesrvAddr("localhost:8080");

        consumer.subscribe("topic", "*");
        consumer.registerMessageListener(new MessageListenerConcurrently() {

            @Override
            public ConsumeConcurrentlyStatus consumeMessage(List<MessageExt> msgs, ConsumeConcurrentlyContext context) {
                System.out.printf("%s Receive New Messages: %s %n", Thread.currentThread().getName(), msgs);
                return ConsumeConcurrentlyStatus.RECONSUME_LATER;
            }
        });

What Did You Expect to See?

send message back request contains brokerName.

What Did You See Instead?

brokerName is null in send message back request.

Additional Context

No response

lizhanhui pushed a commit that referenced this issue Aug 30, 2024
* fix missing brokerName in sendMessageBack request

* fix
lizhanhui pushed a commit to qianye1001/rocketmq that referenced this issue Aug 30, 2024
…apache#8585)

* fix missing brokerName in sendMessageBack request

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant