Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for putting duplicated messsages while sending batch message #4466

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

jameslcj
Copy link
Contributor

What is the purpose of the change

Fix bug for putting duplicated messsages while sending batch message

Brief changelog

Remove the redundant code

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 47.327% when pulling acbc6f9 on jameslcj:5.0.0-beta into 33fd330 on apache:5.0.0-beta.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #4466 (acbc6f9) into 5.0.0-beta (33fd330) will increase coverage by 0.02%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             5.0.0-beta    #4466      +/-   ##
================================================
+ Coverage         43.15%   43.17%   +0.02%     
- Complexity         6064     6069       +5     
================================================
  Files               801      801              
  Lines             57087    57086       -1     
  Branches           7805     7805              
================================================
+ Hits              24637    24648      +11     
+ Misses            29229    29221       -8     
+ Partials           3221     3217       -4     
Impacted Files Coverage Δ
...ocketmq/broker/processor/SendMessageProcessor.java 45.64% <ø> (+0.13%) ⬆️
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-5.00%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (-2.57%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 49.17% <0.00%> (-0.56%) ⬇️
...ava/org/apache/rocketmq/store/MappedFileQueue.java 54.85% <0.00%> (-0.53%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 44.91% <0.00%> (-0.38%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 61.00% <0.00%> (+0.45%) ⬆️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 58.97% <0.00%> (+0.51%) ⬆️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.95% <0.00%> (+0.51%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33fd330...acbc6f9. Read the comment docs.

@RongtongJin RongtongJin merged commit cd24a24 into apache:5.0.0-beta Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants