Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8289] Fixed network bugs and merged networkutil code #8290

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

zekai-li
Copy link
Contributor

Fix the following three as
1,TraceBean: private static final String LOCAL_ADDRESS = UtilAll.ipToIPv4Str(UtilAll.getIP()); getIP mayby ipv6
2,NetworkUtil:if (ip.startsWith("127.0") || ip.startsWith("192.168") || ip.startsWith("0."));Check whether Intranet errors exist

Which Issue(s) This PR Fixes

Fixes #8289

Brief Description

How Did You Test This Change?

Fix the following three as
1,TraceBean: private static final String LOCAL_ADDRESS = UtilAll.ipToIPv4Str(UtilAll.getIP()); getIP mayby ipv6
2,NetworkUtil:if (ip.startsWith("127.0") || ip.startsWith("192.168") || ip.startsWith("0."));Check whether Intranet errors exist
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 58.73016% with 26 lines in your changes missing coverage. Please review.

Project coverage is 42.87%. Comparing base (1a73e01) to head (38be751).
Report is 4 commits behind head on develop.

Files Patch % Lines
.../org/apache/rocketmq/common/utils/NetworkUtil.java 58.69% 12 Missing and 7 partials ⚠️
.../main/java/org/apache/rocketmq/common/UtilAll.java 58.33% 1 Missing and 4 partials ⚠️
...va/org/apache/rocketmq/client/trace/TraceBean.java 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8290      +/-   ##
=============================================
- Coverage      42.90%   42.87%   -0.04%     
+ Complexity     10408    10400       -8     
=============================================
  Files           1274     1274              
  Lines          88952    88966      +14     
  Branches       11438    11443       +5     
=============================================
- Hits           38168    38147      -21     
- Misses         46076    46101      +25     
- Partials        4708     4718      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fix the following three as
1,TraceBean: private static final String LOCAL_ADDRESS = UtilAll.ipToIPv4Str(UtilAll.getIP()); getIP mayby ipv6
2,NetworkUtil:if (ip.startsWith("127.0") || ip.startsWith("192.168") || ip.startsWith("0."));Check whether Intranet errors exist
@zekai-li zekai-li requested a review from drpmma June 13, 2024 05:58
Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francisoliverlee francisoliverlee merged commit aa788e8 into apache:develop Aug 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] networkutil code logical errors
5 participants