Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8365] add remoting client non-oneway updateConsumerOffset function #8391

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

qianye1001
Copy link
Contributor

Which Issue(s) This PR Fixes
Enhancement #8365

Brief Description
add remoting client non-oneway updateConsumerOffset function

How Did You Test This Change?
add some new unit test

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 18 lines in your changes missing coverage. Please review.

Project coverage is 44.31%. Comparing base (6f77f05) to head (072bdb1).
Report is 1 commits behind head on develop.

Files Patch % Lines
...he/rocketmq/proxy/processor/ConsumerProcessor.java 12.50% 14 Missing ⚠️
...q/proxy/service/message/ClusterMessageService.java 0.00% 2 Missing ⚠️
...tmq/proxy/processor/DefaultMessagingProcessor.java 50.00% 1 Missing ⚠️
...tmq/proxy/service/message/LocalMessageService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8391      +/-   ##
=============================================
- Coverage      44.36%   44.31%   -0.05%     
+ Complexity     10782    10769      -13     
=============================================
  Files           1274     1274              
  Lines          88951    88968      +17     
  Branches       11433    11433              
=============================================
- Hits           39463    39427      -36     
- Misses         44535    44577      +42     
- Partials        4953     4964      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpmma drpmma merged commit 1588d65 into apache:develop Jul 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants