-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute #8477
[ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute #8477
Conversation
add test case for AclConfig in commom module Fixes apache#8417 Brief Description add test case for AclConfig in commom module by using tongyi tools. How Did You Test This Change? run test case successfull.
[ISSUE apache#8417]add some test cases for org.apache.rocketmq.common.AclConfig apache#8417
…elop # Conflicts: # common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java
add test case for AclConfig in commom module Fixes apache#8476 Brief Description add test case for org.apache.rocketmq.common.attribute in commom module by using tongyi tools. How Did You Test This Change? run test case successfull.
add test case for AclConfig in commom module Fixes apache#8476 Brief Description add test case for org.apache.rocketmq.common.attribute in commom module by using tongyi tools. How Did You Test This Change? run test case successfull.
for soc in #8262 . |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8477 +/- ##
=============================================
- Coverage 46.04% 46.02% -0.02%
- Complexity 11147 11151 +4
=============================================
Files 1274 1274
Lines 89000 89000
Branches 11443 11443
=============================================
- Hits 40979 40962 -17
- Misses 42905 42914 +9
- Partials 5116 5124 +8 ☔ View full report in Codecov by Sentry. |
…-tests-for-attribute
add test case for AclConfig in commom module Fixes apache#8476 Brief Description add test case for org.apache.rocketmq.common.attribute in commom module by using tongyi tools. How Did You Test This Change? run test case successfull.
I see a lot of people having this problem, what can be done to fix it? |
This bazel-build check isn't 'required' for pr merging, but u can try to fix these flaky tests if you are interested in this question. |
Got it, thanks a lot!!! |
@TeFuirnever A reminder from the Tianchi platform: it‘s better to submit your results to the official website asap. |
Got it, thanks so much! It was a great event! |
Hello, how about merged the code, I'm going to move on to other UT tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which Issue(s) This PR Fixes
[Enhancement] Add test cases for org.apache.rocketmq.common.attribute #8476
Fixes #8476
Brief Description
Add more test coverage for Add test cases for org.apache.rocketmq.common.attribute.
How Did You Test This Change?
run test case successfull.