Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8481] Improve delete and rolling strategy for tiered storage modules #8493

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

lizhimins
Copy link
Member

@lizhimins lizhimins commented Aug 5, 2024

[ISSUE #8481] Improve delete and rolling strategy for tiered storage modules

Which Issue(s) This PR Fixes

Fixes #8481

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.63291% with 39 lines in your changes missing coverage. Please review.

Project coverage is 46.23%. Comparing base (304987d) to head (5e37c69).
Report is 15 commits behind head on develop.

Files Patch % Lines
.../rocketmq/tieredstore/index/IndexStoreService.java 30.76% 15 Missing and 3 partials ⚠️
...pache/rocketmq/tieredstore/file/FlatFileStore.java 0.00% 15 Missing ⚠️
...pache/rocketmq/tieredstore/TieredMessageStore.java 71.42% 0 Missing and 2 partials ⚠️
...pache/rocketmq/tieredstore/MessageStoreConfig.java 88.88% 1 Missing ⚠️
...etmq/tieredstore/core/MessageStoreFetcherImpl.java 90.00% 0 Missing and 1 partial ⚠️
...e/rocketmq/tieredstore/file/FlatCommitLogFile.java 80.00% 0 Missing and 1 partial ⚠️
...pache/rocketmq/tieredstore/index/IndexService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8493      +/-   ##
=============================================
+ Coverage      45.92%   46.23%   +0.30%     
- Complexity     11104    11207     +103     
=============================================
  Files           1274     1275       +1     
  Lines          89001    89061      +60     
  Branches       11441    11454      +13     
=============================================
+ Hits           40875    41177     +302     
+ Misses         43027    42751     -276     
- Partials        5099     5133      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LetLetMe LetLetMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常好写的

@lizhimins lizhimins merged commit f63a3ba into apache:develop Aug 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Improve delete and rolling strategy for tiered storage modules
4 participants