Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8576] Support Creating or Updating Subscription Groups in Batch #8577

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

caigy
Copy link
Contributor

@caigy caigy commented Aug 23, 2024

Which Issue(s) This PR Fixes

Fixes #8576

Brief Description

How Did You Test This Change?

support creating or updating groups in batch

support creating or updating groups in batch

support creating or updating groups in batch
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.83333% with 76 lines in your changes missing coverage. Please review.

Project coverage is 47.21%. Comparing base (7444aa2) to head (5236ff9).

Files Patch % Lines
...command/consumer/UpdateSubGroupListSubCommand.java 28.88% 32 Missing ⚠️
...ocketmq/broker/processor/AdminBrokerProcessor.java 0.00% 23 Missing ⚠️
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 0.00% 9 Missing ⚠️
.../remoting/protocol/body/SubscriptionGroupList.java 0.00% 7 Missing ⚠️
...apache/rocketmq/tools/admin/DefaultMQAdminExt.java 0.00% 2 Missing ⚠️
...he/rocketmq/tools/admin/DefaultMQAdminExtImpl.java 0.00% 2 Missing ⚠️
.../apache/rocketmq/tools/command/MQAdminStartup.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8577      +/-   ##
=============================================
- Coverage      47.29%   47.21%   -0.09%     
+ Complexity     11457    11451       -6     
=============================================
  Files           1275     1277       +2     
  Lines          89242    89338      +96     
  Branches       11470    11479       +9     
=============================================
- Hits           42207    42178      -29     
- Misses         41834    41956     +122     
- Partials        5201     5204       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RongtongJin RongtongJin merged commit a1ea1eb into apache:develop Aug 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support Creating or Updating Subscription Groups in Batch
4 participants