[ISSUE #8592] Not notify long polling request when pop orderly consume blocked #8593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consume blocked
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8593 +/- ##
=============================================
- Coverage 47.23% 47.20% -0.03%
+ Complexity 11464 11458 -6
=============================================
Files 1277 1277
Lines 89342 89342
Branches 11480 11480
=============================================
- Hits 42202 42177 -25
- Misses 41939 41967 +28
+ Partials 5201 5198 -3 ☔ View full report in Codecov by Sentry. |
lollipopjin
reviewed
Aug 28, 2024
| if (isOrder) { | ||
| if (brokerController.getConsumerOrderInfoManager().checkBlock( | ||
| attemptId, topic, requestHeader.getConsumerGroup(), queueId, requestHeader.getInvisibleTime())) { | ||
| // should not add accumulation(max offset - consumer offset) here |
There was a problem hiding this comment.
LGTM，Means return the original restNum if lock failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8592
Brief Description
How Did You Test This Change?