Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8599] Fix send fail without retry when get GO_AWAY twice #8603

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

qianye1001
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8599

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.20%. Comparing base (4c51706) to head (db4e586).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...rocketmq/remoting/netty/NettyRemotingAbstract.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8603      +/-   ##
=============================================
- Coverage      47.27%   47.20%   -0.07%     
+ Complexity     11488    11469      -19     
=============================================
  Files           1277     1277              
  Lines          89425    89432       +7     
  Branches       11502    11502              
=============================================
- Hits           42272    42214      -58     
- Misses         41948    42007      +59     
- Partials        5205     5211       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lizhimins
lizhimins previously approved these changes Aug 30, 2024
@lizhanhui
Copy link
Contributor

lizhanhui commented Aug 30, 2024

Rebase to apply commit 1a15729, which limits rate of appending DLedger commit log.

lizhanhui
lizhanhui previously approved these changes Aug 30, 2024
@lizhanhui lizhanhui dismissed stale reviews from lizhimins and themself via 0ce0930 August 30, 2024 10:15
@qianye1001
Copy link
Contributor Author

@lizhanhui , macos still fail

@lizhimins lizhimins merged commit 0b0f8ec into apache:develop Sep 5, 2024
11 checks passed
@qianye1001 qianye1001 deleted the issue8599 branch September 12, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize the graceful shutdown for the proxy remoting protocol server.
4 participants