[ISSUE #8618] Supports getting consumer group information for all pop patterns on the broker #8619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8619 +/- ##
=============================================
- Coverage 47.45% 47.38% -0.08%
+ Complexity 11617 11603 -14
=============================================
Files 1284 1284
Lines 90025 90033 +8
Branches 11585 11587 +2
=============================================
- Hits 42724 42664 -60
- Misses 42065 42120 +55
- Partials 5236 5249 +13 ☔ View full report in Codecov by Sentry. |
lizhimins
reviewed
Sep 5, 2024
| public MessageRequestModeSerializeWrapper getAllMessageRequestMode(final String brokerAddr) throws MQBrokerException, | ||
| RemotingConnectException, RemotingSendRequestException, RemotingTimeoutException, InterruptedException { | ||
| RemotingCommand request = RemotingCommand.createRequestCommand(RequestCode.GET_ALL_MESSAGE_REQUEST_MODE, null); | ||
| RemotingCommand response = this.remotingClient.invokeSync(brokerAddr, request, 3000); |
There was a problem hiding this comment.
may timeout when execute get all
There was a problem hiding this comment.
The local test does not time out, I can increase the timeout parameter if necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8618
Brief Description
How Did You Test This Change?