Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8657] Make retry topic pop probability configurable #8658

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

GenerousMan
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8657

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.39%. Comparing base (5496807) to head (30e9cfc).
Report is 45 commits behind head on develop.

Files with missing lines Patch % Lines
.../java/org/apache/rocketmq/common/BrokerConfig.java 25.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8658      +/-   ##
=============================================
- Coverage      47.42%   47.39%   -0.04%     
+ Complexity     11514    11506       -8     
=============================================
  Files           1277     1277              
  Lines          89438    89442       +4     
  Branches       11502    11502              
=============================================
- Hits           42416    42391      -25     
- Misses         41812    41839      +27     
- Partials        5210     5212       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins lizhimins changed the title [ISSUE #8657]make retry topic pop probability configurable. [ISSUE #8657] Make retry topic pop probability configurable Sep 7, 2024
@RongtongJin RongtongJin merged commit 9b53c06 into apache:develop Sep 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] The POP probability for the Retry Topic should be configurable
5 participants