Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8669] Fix crc 32 overflow when lmq #8670

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

DongyuanPan
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8669

Brief Description

How Did You Test This Change?

@RongtongJin RongtongJin changed the title fix crc 32 overflow when lmq [ISSUE #8669] Fix crc 32 overflow when lmq Sep 9, 2024
Copy link
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.39%. Comparing base (9b53c06) to head (fabd7dd).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8670      +/-   ##
=============================================
- Coverage      47.44%   47.39%   -0.05%     
+ Complexity     11515    11507       -8     
=============================================
  Files           1277     1277              
  Lines          89442    89442              
  Branches       11502    11502              
=============================================
- Hits           42436    42395      -41     
- Misses         41801    41834      +33     
- Partials        5205     5213       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin merged commit ba8148f into apache:develop Sep 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] crc 32 overflow when use lmq
4 participants