-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #8698] Remove batch write in kv cq store and update rocksdb cq check tool #8739
Conversation
store/src/main/java/org/apache/rocketmq/store/queue/RocksDBConsumeQueueStore.java
Outdated
Show resolved
Hide resolved
In order to minimize changes, we have opted to set the batch_size to 1 this time. However, this solution is not perfect, and we will need to use a more rigorous approach in the future to completely resolve this issue. 为了尽量少的变更,我们此次采用了batch_size改为1的方式,但这个方案不完美,后续还是要用更严谨的方式,彻底修复这个问题 |
To avoid changing the default logic of the currently deployed cluster, we will make the batch_size configurable and consider a complete optimization later. @RongtongJin 为了不改变现有已部署集群的默认逻辑,我们把batch_size改为可配置,后续在考虑彻底优化 @RongtongJin |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8739 +/- ##
=============================================
- Coverage 47.48% 47.34% -0.15%
+ Complexity 11571 11549 -22
=============================================
Files 1282 1282
Lines 89813 89848 +35
Branches 11553 11557 +4
=============================================
- Hits 42652 42536 -116
- Misses 41928 42063 +135
- Partials 5233 5249 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Which Issue(s) This PR Fixes
Brief Description
How Did You Test This Change?