Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8742] Enhance unit test retry mechanism to trigger on PR submission #8741

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

chi3316
Copy link
Contributor

@chi3316 chi3316 commented Sep 24, 2024

Which Issue(s) This PR Fixes

Fixes #8742

Brief Description

  • Modified the retry mechanism to use the workflow_run event instead of manual rerun.
  • Resolved permission issues preventing retry on PR submission.
  • Improved automation and stability of unit tests.

How Did You Test This Change?

I tested the change by submitting a PR to my own repository and deliberately introducing errors to check if the retry mechanism would trigger. The result was successful, confirming that the retry function works as intended.

The test workflow

image

@chi3316 chi3316 changed the title Enhance unit test retry mechanism to trigger on PR submission [ISSUE #8742] Enhance unit test retry mechanism to trigger on PR submission Sep 24, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.39%. Comparing base (525f877) to head (8f5937b).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8741      +/-   ##
=============================================
- Coverage      47.46%   47.39%   -0.07%     
+ Complexity     11566    11557       -9     
=============================================
  Files           1282     1282              
  Lines          89813    89813              
  Branches       11553    11553              
=============================================
- Hits           42626    42566      -60     
- Misses         41956    42005      +49     
- Partials        5231     5242      +11     
Flag Coverage Δ
47.39% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8742

Brief Description

  • Modified the retry mechanism to use the workflow_run event instead of manual rerun.
  • Resolved permission issues preventing retry on PR submission.
  • Improved automation and stability of unit tests.

How Did You Test This Change?

I tested the change by submitting a PR to my own repository and deliberately introducing errors to check if the retry mechanism would trigger. The result was successful, confirming that the retry function works as intended.

The test workflow

image

Good job

@RongtongJin RongtongJin merged commit a8dde86 into apache:develop Sep 25, 2024
11 checks passed
@chi3316 chi3316 deleted the retry-pr branch September 25, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Improve unit test retry mechanism for PR submissions
3 participants