Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8764] Implement consume lag estimation in cq rocksdb store #8800

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

LetLetMe
Copy link
Contributor

@LetLetMe LetLetMe commented Oct 9, 2024

Which Issue(s) This PR Fixes

Fixes #8764

Brief Description

How Did You Test This Change?

@LetLetMe LetLetMe changed the title Implementation of kvcq message heap estimation Implementation of kvcq message pile estimation Oct 9, 2024
@LetLetMe LetLetMe changed the title Implementation of kvcq message pile estimation Implementation of kvcq message lag estimation Oct 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 47.69%. Comparing base (daf3d1a) to head (ce7dda6).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...ache/rocketmq/store/queue/RocksDBConsumeQueue.java 73.91% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8800      +/-   ##
=============================================
+ Coverage      47.52%   47.69%   +0.17%     
- Complexity     11592    11828     +236     
=============================================
  Files           1282     1283       +1     
  Lines          89848    90709     +861     
  Branches       11557    11737     +180     
=============================================
+ Hits           42697    43261     +564     
- Misses         41927    42175     +248     
- Partials        5224     5273      +49     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lizhimins lizhimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还需要评估下不同使用场景下的影响,例如队列数量极多时

RongtongJin
RongtongJin previously approved these changes Oct 11, 2024
RongtongJin
RongtongJin previously approved these changes Oct 12, 2024
lollipopjin
lollipopjin previously approved these changes Oct 12, 2024
@lizhimins lizhimins changed the title Implementation of kvcq message lag estimation [ISSUE #8764] Implement consume lag estimation in cq rocksdb store Oct 15, 2024
@lizhimins lizhimins merged commit 2fa7513 into apache:develop Oct 15, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Implementation of kvcq message lag estimation
5 participants