Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: atomic flush incorrect use and clean up code #8830

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

lizhanhui
Copy link
Contributor

Which Issue(s) This PR Fixes

to #8829

Brief Description

How Did You Test This Change?

Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 9.49367% with 143 lines in your changes missing coverage. Please review.

Project coverage is 47.38%. Comparing base (4f5f705) to head (979d4d0).

Files with missing lines Patch % Lines
...rocketmq/common/config/AbstractRocksDBStorage.java 0.00% 68 Missing ⚠️
...rg/apache/rocketmq/common/config/ConfigHelper.java 0.00% 65 Missing ⚠️
...e/rocketmq/common/config/ConfigRocksDBStorage.java 0.00% 10 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8830      +/-   ##
=============================================
- Coverage      47.51%   47.38%   -0.14%     
+ Complexity     11631    11599      -32     
=============================================
  Files           1283     1284       +1     
  Lines          90009    90017       +8     
  Branches       11584    11585       +1     
=============================================
- Hits           42771    42656     -115     
- Misses         42008    42110     +102     
- Partials        5230     5251      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhanhui lizhanhui merged commit 49e23e1 into apache:develop Oct 18, 2024
11 checks passed
@lizhanhui lizhanhui deleted the fix_atomic_flush branch October 18, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants