Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9044]Supplemental checks that are missing from the UpdateSubGroup&UpdateSubGroupList  operation #9058

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Willhow-Gao
Copy link
Contributor

import org.apache.rocketmq.remoting.protocol.body.QueryCorrectionOffsetBody;
import org.apache.rocketmq.remoting.protocol.body.UnlockBatchRequestBody;
import org.apache.rocketmq.remoting.protocol.body.UserInfo;
import org.apache.rocketmq.remoting.protocol.body.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkstyle

Copy link
Contributor Author

@Willhow-Gao Willhow-Gao Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkstyle

fixed

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.10%. Comparing base (93e2689) to head (820109a).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...ocketmq/broker/processor/AdminBrokerProcessor.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9058      +/-   ##
=============================================
+ Coverage      47.97%   48.10%   +0.12%     
- Complexity     11904    11915      +11     
=============================================
  Files           1312     1312              
  Lines          91735    92324     +589     
  Branches       11751    11992     +241     
=============================================
+ Hits           44014    44413     +399     
- Misses         42312    42470     +158     
- Partials        5409     5441      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Willhow-Gao Willhow-Gao requested a review from humkum December 21, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Empty consumer groups can be created but cannot be consumed
3 participants