[LDAP][Seatunnel-web] Add ldap support for seatunnel web api calls #245
Conversation
|
Can you change the dependenet jar to What do you think? |
In ConfiguredAuthenticationProvider#L45 we are using an out of box AuthenticationProvider. Are you suggesting to change the implementation? |
| "Error while authenticating user : {}, reason :{}", | ||
| authentication.getName(), | ||
| ex.getMessage()); | ||
| ex.printStackTrace(); |
There was a problem hiding this comment.
remove the stack trace
| return Result.success(iUserService.login(req)); | ||
| public Result<UserSimpleInfoRes> login( | ||
| @RequestBody UserLoginReq req, | ||
| @RequestHeader(value = "Auth-Type", required = false) String authType) { |
There was a problem hiding this comment.
can we make the auth-type part of UserLoginReq?
| // 2. add a new user. | ||
| final UpdateUserDto dto = | ||
| UpdateUserDto.builder().id(null).username(username).password("").build(); | ||
| userDaoImpl.add(dto); |
There was a problem hiding this comment.
After the first login, an LDAP user is added to the database. From the second login onwards, the same user can log in as a DB_USER by just not providing Auth-Type header.
There should be a way to differentiate between user types.
| spring-plugin-core-1.2.0.RELEASE.jar | ||
| spring-plugin-metadata-1.2.0.RELEASE.jar | ||
| spring-security-core-6.3.0.jar | ||
| spring-security-ldap-6.3.0.jar |
There was a problem hiding this comment.
is spring 6.x java 8 compatible? can you use java 8 compatible version of spring?
|
@BilwaST Are you still working on this? |
Purpose of this pull request
Check list
New License Guide