Improve task deploy state change

apache · Sep 14, 2023 · 9fc2022 · 9fc2022
1 parent 7ed36ea
commit 9fc2022
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/...er/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java b/...er/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java
@@ -414,8 +414,7 @@ protected void tryTriggerPendingCheckpoint(CheckpointType checkpointType) {
 
  if (pendingCounter.get() > 0) {
  scheduleTriggerPendingCheckpoint(checkpointType, 500L);
- LOG.info(
- "skip trigger checkpoint because there is already a pending checkpoint.");
+ LOG.info("skip trigger checkpoint because there is already a pending checkpoint.");
  return;
  }
 

diff --git a/...-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PhysicalVertex.java b/...-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PhysicalVertex.java
@@ -320,14 +320,9 @@ private TaskDeployState deployInternal(
  Function<TaskGroupImmutableInformation, TaskDeployState> taskGroupConsumer) {
  TaskGroupImmutableInformation taskGroupImmutableInformation =
  getTaskGroupImmutableInformation();
- synchronized (this) {
- if (ExecutionState.DEPLOYING.equals(currExecutionState)) {
- TaskDeployState state = taskGroupConsumer.apply(taskGroupImmutableInformation);
- updateTaskState(ExecutionState.DEPLOYING, ExecutionState.RUNNING);
- return state;
- }
- return TaskDeployState.success();
- }
+ TaskDeployState state = taskGroupConsumer.apply(taskGroupImmutableInformation);
+ updateTaskState(ExecutionState.DEPLOYING, ExecutionState.RUNNING);
+ return state;
  }
 
  private TaskGroupImmutableInformation getTaskGroupImmutableInformation() {

diff --git a/...er/src/test/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointTimeOutTest.java b/...er/src/test/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointTimeOutTest.java
@@ -25,7 +25,6 @@
 import org.apache.seatunnel.engine.server.TestUtils;
 
 import org.junit.jupiter.api.Assertions;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import com.hazelcast.internal.serialization.Data;