Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Connector-V2] Add influxDB connector source #2595

Closed
wants to merge 15 commits into from
Closed

[Feature][Connector-V2] Add influxDB connector source #2595

wants to merge 15 commits into from

Conversation

531651225
Copy link
Contributor

#1946
Add InfluxDB Connector Source

Purpose of this pull request

Check list

@531651225 531651225 requested review from CalvinKirs and hailin0 and removed request for CalvinKirs and hailin0 September 2, 2022 15:36
@531651225
Copy link
Contributor Author

@hailin0 @CalvinKirs @EricJoy2048 Hi brothers, please help me review.
图片

Integration test phase fails. How to solve this problem? My local E2E can pass

@hailin0
Copy link
Member

hailin0 commented Sep 5, 2022

image

https://pipelines.actions.githubusercontent.com/serviceHosts/5f1d2e93-1249-42e2-b16d-ed31c598c5d5/_apis/pipelines/1/runs/17499/signedlogcontent/36?urlExpires=2022-09-05T12%3A40%3A16.6214641Z&urlSigningMethod=HMACV1&urlSignature=pxCWdlIluLkqSV6lJ5ns5Fi9zSQKLy5Id%2FTDwE6xljY%3D

Please check for dependency jar conflicts

@531651225
Copy link
Contributor Author

image https://pipelines.actions.githubusercontent.com/serviceHosts/5f1d2e93-1249-42e2-b16d-ed31c598c5d5/_apis/pipelines/1/runs/17499/signedlogcontent/36?urlExpires=2022-09-05T12%3A40%3A16.6214641Z&urlSigningMethod=HMACV1&urlSignature=pxCWdlIluLkqSV6lJ5ns5Fi9zSQKLy5Id%2FTDwE6xljY%3D

Please check for dependency jar conflicts
Thank you for your pr #2648. I solved the conflict for dependency jar in
flink e2e

@531651225 531651225 requested review from EricJoy2048 and removed request for CalvinKirs September 7, 2022 05:12
EricJoy2048
EricJoy2048 reviewed Sep 7, 2022
View reviewed changes
docs/en/connector-v2/source/InfluxDB.md
the `query_timeout` of the InfluxDB when you select, in seconds

### connect_timeout_ms [long]
the timeout for connecting to InfluxDB, in milliseconds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some example for this connector. You can refer to the documentation of other connectors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some example for this connector. You can refer to the documentation of other connectors.

Thank you for your suggestion, I have added in new commit

EricJoy2048
EricJoy2048 reviewed Sep 7, 2022
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @hailin0 @CalvinKirs PHAL

ic4y
ic4y reviewed Sep 7, 2022
View reviewed changes
pom.xml Outdated
Comment on lines 437 to 442

<dependency>
<groupId>org.influxdb</groupId>
<artifactId>influxdb-java</artifactId>
<version>${influxdb.version}</version>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connector-specific dependencies are now managed under seatunnel-connectors-v2/connector-influxdb/pom.xml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connector-specific dependencies are now managed under seatunnel-connectors-v2/connector-influxdb/pom.xml

ok, i have fixed in new commit

@531651225 531651225 requested a review from ic4y September 7, 2022 12:50
@531651225 531651225 closed this Sep 9, 2022
@531651225 531651225 deleted the Infuxdb-connector-source branch September 9, 2022 03:22
@531651225 531651225 mentioned this pull request Sep 9, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricJoy2048 EricJoy2048 EricJoy2048 left review comments

@CalvinKirs CalvinKirs CalvinKirs left review comments

@hailin0 hailin0 hailin0 left review comments

@ic4y ic4y Awaiting requested review from ic4y

Assignees
No one assigned
Labels
connectors-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@531651225 @hailin0 @CalvinKirs @EricJoy2048 @ic4y