[#2606]Dependency management split #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
reviewed
Sep 3, 2022
Comment on lines
+37
to
+46
| <dependency> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpcore</artifactId> | ||
| <version>${httpcore.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpclient</artifactId> | ||
| <version>${httpclient.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
hi, the http dependency plugin is actually a required option, and it was previously provided as a provide item. When we extract it to the parent dependency and provide it as a provider, it will have problems.
|
Hi, all |
Hi, thx your reminder. done |
|
seem like ci have some problem should be fixed before merge. |
|
hi, done.This is due to provide dependency transitivity, so I added the dependency of seatunnel-api in the parent pom |
Hisoka-X
approved these changes
Sep 5, 2022
This was referenced Sep 6, 2022
3 tasks
MRYOG
pushed a commit
to MRYOG/incubator-seatunnel
that referenced
this pull request
Sep 8, 2022
* [apache#2606]Dependency management split apache#2606 subtask * set seatunnel-api scope to provide * add seatunnel-api dependency
laglangyue
pushed a commit
to laglangyue/seatunnel
that referenced
this pull request
Sep 11, 2022
* [apache#2606]Dependency management split apache#2606 subtask * set seatunnel-api scope to provide * add seatunnel-api dependency
MRYOG
pushed a commit
to MRYOG/incubator-seatunnel
that referenced
this pull request
Sep 15, 2022
* [apache#2606]Dependency management split apache#2606 subtask * set seatunnel-api scope to provide * add seatunnel-api dependency
MRYOG
pushed a commit
to MRYOG/incubator-seatunnel
that referenced
this pull request
Sep 16, 2022
* [apache#2606]Dependency management split apache#2606 subtask * set seatunnel-api scope to provide * add seatunnel-api dependency
TyrantLucifer
pushed a commit
to TyrantLucifer/incubator-seatunnel
that referenced
this pull request
Sep 18, 2022
* [apache#2606]Dependency management split apache#2606 subtask * set seatunnel-api scope to provide * add seatunnel-api dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2606 subtask