Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Engine] [Checkpoint] fix Checkpoint can't deserialize with protostuff #3131

Merged
merged 1 commit into from
Oct 19, 2022
Merged

[Engine] [Checkpoint] fix Checkpoint can't deserialize with protostuff #3131

merged 1 commit into from
Oct 19, 2022

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

fix Checkpoint can't deserialize with protostuff.

Check list

@Hisoka-X Hisoka-X added the Zeta label Oct 18, 2022
ashulin
ashulin approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EricJoy2048
EricJoy2048 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@EricJoy2048 EricJoy2048 merged commit 4cecedb into apache:dev Oct 19, 2022
@Hisoka-X Hisoka-X deleted the protostuff_bug branch October 19, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashulin ashulin ashulin approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

Assignees
No one assigned
Labels
Zeta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hisoka-X @EricJoy2048 @ashulin