[Feature][Connector-V2] rabbitmq source and sink connector #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 27, 2022 06:59
TaoZex
reviewed
Nov 6, 2022
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/config/RabbitmqConfig.java
Show resolved
Hide resolved
...rc/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/sink/RabbitmqSinkWriter.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/sink/RabbitmqSinkWriter.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/client/RabbitmqClient.java
Show resolved
Hide resolved
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/source/RabbitmqSource.java
Show resolved
Hide resolved
...itmq/src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/sink/RabbitmqSink.java
Show resolved
Hide resolved
531651225
changed the title
531651225
changed the title
EricJoy2048
reviewed
Nov 8, 2022
...rc/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/client/QueueingConsumer.java
Outdated
Show resolved
Hide resolved
|
Hi, @531651225 Resolve the conflicts please. |
added 2 commits
November 9, 2022 23:04
thinks，have fixed. |
hailin0
reviewed
Nov 11, 2022
...atunnel-connector-v2-e2e/connector-rabbitmq-e2e/src/test/resources/rabbitmq-to-rabbitmq.conf
Outdated
Show resolved
Hide resolved
...atunnel-connector-v2-e2e/connector-rabbitmq-e2e/src/test/resources/rabbitmq-to-rabbitmq.conf
Outdated
Show resolved
Hide resolved
added 2 commits
November 15, 2022 13:31
531651225
requested review from
TyrantLucifer
and removed request for
hailin0 and
TyrantLucifer
There was a problem hiding this comment.
BTW, please update this docs https://seatunnel.apache.org/docs/connector-v2/Error-Quick-Reference-Manual and implement option factory, you can refer to #3320 and https://github.com/apache/incubator-seatunnel/pull/3343/files#diff-bd574bf2e6ec89cc4f480b1f22c59516d721a61f3b9ab8edea4dfa569eebcd55
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/client/RabbitmqClient.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/client/RabbitmqClient.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/client/RabbitmqClient.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/client/RabbitmqClient.java
Outdated
Show resolved
Hide resolved
thinks, added option factory and update error-Quick-Reference-Manual , PTAL. @TyrantLucifer |
...itmq/src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/sink/RabbitmqSink.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/source/RabbitmqSource.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/source/RabbitmqSource.java
Outdated
Show resolved
Hide resolved
EricJoy2048
previously approved these changes
Nov 24, 2022
seatunnel-dist/pom.xml
Outdated
| @@ -366,6 +366,7 @@ | |||
| <dependency> | |||
| <groupId>org.apache.seatunnel</groupId> | |||
| <artifactId>connector-rabbitmq</artifactId> | |||
| <artifactId>connector-http-jira</artifactId> | |||
There was a problem hiding this comment.
Revert? and add ne dependency for your connector?
EricJoy2048
approved these changes
Nov 24, 2022
|
@TyrantLucifer PTAL |
Waiting CI. |
TyrantLucifer
approved these changes
Nov 24, 2022
3 tasks
|
@531651225 hi ,usesCorrelationId可配置吗，有些老的消息没有correlation_id |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
refer to #3018
add rabbitmq connector
Check list
New License Guide