Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Refactor CatalogTable and add SeaTunnelSource::getProducedCatalogTables #5562

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

  1. Add getProducedCatalogTables in SeaTunnelSource. After this, the CatalogTable should be generated by SeaTunnelSource, not in MultipleTableJobConfigParser. Also mark getProducedType as deprecated.
  2. Remove useless class SupportMultipleTable, we use catalogtable list size which return by getProducedCatalogTables to identify support multiple table or not.
  3. Change TableFactoryContext as abstrct class, with these implement class: TableSourceFactoryContext, TableTransformFactoryContext, TableSinkFactoryContext.

Does this PR introduce any user-facing change?

No, just zeta and connector refactor.

How was this patch tested?

exist test.

Check list

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit 4117335 into apache:dev Sep 28, 2023
4 checks passed
@Hisoka-X Hisoka-X deleted the refactor-multipleparser branch October 8, 2023 03:04
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants