[Feature] Support multi-table sink #5620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
4 tasks
hailin0
reviewed
Oct 16, 2023
...tor-fake-e2e/src/test/java/org/apache/seatunnel/e2e/connector/fake/FakeWithMultiTableTT.java
Show resolved
Hide resolved
Hisoka-X
force-pushed
the
multi-table-sink
branch
from
7bd52e8 to
ad6e537
Compare
hailin0
reviewed
Oct 17, 2023
...or-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql_with_multi_table.conf
Outdated
Show resolved
Hide resolved
...e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/util/ContainerUtil.java
Outdated
Show resolved
Hide resolved
...erver/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java
Show resolved
Hide resolved
2 tasks
hailin0
previously approved these changes
Oct 20, 2023
ruanwenjun
previously approved these changes
Oct 20, 2023
| @@ -170,7 +170,7 @@ public CheckpointCoordinator( | |||
| new ArrayDeque<>(coordinatorConfig.getStorage().getMaxRetainedCheckpoints() + 1); | |||
| this.scheduler = | |||
| Executors.newScheduledThreadPool( | |||
| 2, | |||
| 1, | |||
There was a problem hiding this comment.
Oh I missed it. I think it should be 2.
ruanwenjun
approved these changes
Oct 20, 2023
hailin0
approved these changes
Oct 20, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
no
How was this patch tested?
add new test
Check list
New License Guide
release-note.