Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix][Zeta] Fix taskgroup failed log lost #7241

Merged
merged 2 commits into from
Jul 23, 2024
Merged

[Hotfix][Zeta] Fix taskgroup failed log lost #7241

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c0037a
Fix taskgroup failed log lost
EricJoy2048 Jul 22, 2024
dd2f862
Add test case
EricJoy2048 Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PhysicalVertex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ public PassiveCompletableFuture<TaskExecutionState> initStateFuture() {
}
} else if (ExecutionState.DEPLOYING.equals(currExecutionState)) {
if (!checkTaskGroupIsExecuting(taskGroupLocation)) {
updateTaskState(ExecutionState.RUNNING);
updateTaskState(ExecutionState.FAILING);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Hisoka-X

}
}
return new PassiveCompletableFuture<>(this.taskFuture);
Expand Down Expand Up @@ -485,6 +485,8 @@ private void resetExecutionState() {
() -> {
updateStateTimestamps(ExecutionState.CREATED);
runningJobStateIMap.set(taskGroupLocation, ExecutionState.CREATED);
// reset the errorByPhysicalVertex
errorByPhysicalVertex = new AtomicReference<>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seatunnel/seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/sink/inmemory/InMemorySinkWriter.java

Line 80 in 4b3af9b

if (config.get(InMemorySinkFactory.THROW_OUT_OF_MEMORY)) {
InMemorySinkWriter is a good choice because it can construct different error messages each time, so you can check the error messages to see if the changes are effective.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use static variables to record the current number of retries

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will try it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

return null;
},
new RetryUtils.RetryMaterial(
Expand Down
Loading