Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Api] Supports simultaneous config of conditions and optional options #7788

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

corgy-w
Copy link
Contributor

@corgy-w corgy-w commented Oct 7, 2024

Purpose of this pull request

conditional does not conflict with optional options

ex: api-path
image

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@github-actions github-actions bot added the api label Oct 7, 2024
liugddx
liugddx previously approved these changes Oct 8, 2024
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Hisoka-X
Copy link
Member

Hisoka-X commented Oct 8, 2024

Thanks @corgy-w

Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@liugddx liugddx merged commit 5bd7f48 into apache:dev Oct 8, 2024
6 checks passed
fcb-xiaobo pushed a commit to fcb-xiaobo/seatunnel that referenced this pull request Oct 11, 2024
CosmosNi pushed a commit to CosmosNi/seatunnel that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants