-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][Api] Supports simultaneous config of conditions and optional options #7788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liugddx
previously approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Hisoka-X
reviewed
Oct 8, 2024
seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/util/OptionRule.java
Outdated
Show resolved
Hide resolved
seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/util/OptionRule.java
Outdated
Show resolved
Hide resolved
Hisoka-X
approved these changes
Oct 8, 2024
Thanks @corgy-w |
liugddx
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
fcb-xiaobo
pushed a commit
to fcb-xiaobo/seatunnel
that referenced
this pull request
Oct 11, 2024
CosmosNi
pushed a commit
to CosmosNi/seatunnel
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
conditional does not conflict with optional options
ex: api-path
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.