Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2] StarRocks-sink support schema evolution #8082

Merged
merged 37 commits into from
Dec 4, 2024

Conversation

jw-itq
Copy link
Contributor

@jw-itq jw-itq commented Nov 19, 2024

Feature #8034

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@Hisoka-X
Copy link
Member

cc @hailin0 @dailai

}

@TestTemplate
public void testStarRocksSinkWithSchemaEvolutionCase(TestContainer container)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

@jw-itq
Copy link
Contributor Author

jw-itq commented Nov 25, 2024

@hailin0 hi,can you help me see the reason why CI did not pass,thanks

}

try {
Connection conn =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not close connection ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not close connection ?

sorry, I'll optimize it

Comment on lines 91 to 92
if (event instanceof AlterTableColumnsEvent) {
AlterTableColumnsEvent alterTableColumnsEvent = (AlterTableColumnsEvent) event;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference
#8158

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,thanks!

@hailin0
Copy link
Member

hailin0 commented Dec 2, 2024

Please fix the ci error

@jw-itq
Copy link
Contributor Author

jw-itq commented Dec 2, 2024

Please fix the ci error

ok!

@jw-itq
Copy link
Contributor Author

jw-itq commented Dec 3, 2024

StarRocksTypeConverter referenced from #8087

Copy link
Contributor

@dailai dailai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit d33b0da into apache:dev Dec 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants