Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Clickhouse] Support sink savemode #8086

Merged
merged 20 commits into from
Dec 4, 2024
Merged

[Feature][Clickhouse] Support sink savemode #8086

merged 20 commits into from
Dec 4, 2024

Conversation

zhangshenghang
Copy link
Member

@zhangshenghang zhangshenghang commented Nov 19, 2024 •
edited by Hisoka-X
Loading

Purpose of this pull request

close #8060

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Hisoka-X
Hisoka-X reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhangshenghang ! Looks great!

...ain/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/catalog/ClickhouseCatalog.java Outdated Show resolved Hide resolved
...a/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/client/ClickhouseSinkWriter.java Outdated Show resolved Hide resolved
...in/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/util/ClickhouseCatalogUtil.java Outdated Show resolved Hide resolved
...c/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/util/CreateTableParser.java Outdated Show resolved Hide resolved
Hisoka-X
Hisoka-X previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @zhangshenghang !

@Hisoka-X
Copy link
Member

Hisoka-X commented Dec 3, 2024

Please resolve conflicts.

Hisoka-X
Hisoka-X previously approved these changes Dec 4, 2024
View reviewed changes
@hailin0 hailin0 merged commit e6f92fd into apache:dev Dec 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@hailin0 hailin0 hailin0 approved these changes

Assignees
No one assigned
Labels
api approved connectors-v2 document e2e reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Clickhouse] Support sink savemode
3 participants
@zhangshenghang @Hisoka-X @hailin0