[Hotfix][Transform][Sql] function concat_ws handle array type， avoid write [Ljava.lang.String. #8369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…write [Ljava.lang.String.
Hisoka-X
reviewed
Dec 24, 2024
| public class ConcatWsFunctionTest { | ||
|
|
||
| @Test | ||
| public void testConcatWs() { |
There was a problem hiding this comment.
Thanks @sohurdc ! Could you add some null value in array to test?
Hisoka-X
previously approved these changes
Dec 24, 2024
add license header to file ConcatWsFunctionTest
|
Please re-try failed ci. |
Hisoka-X
approved these changes
Dec 27, 2024
hailin0
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
When transform from Hive to MySQL, if there are columns of array type, using the concat_ws function for transformation will result in writing [Ljava.lang.String. This is because the array type does not implement the toString method, so special handling is required. Loop through and process the array type one by one.
Does this PR introduce any user-facing change?
No
How was this patch tested?
I added unit tests, but did not add e2e tests.
Check list
New License Guide
release-note.