Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Avro] Fix avro miss convert short type to int #8459

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

hawk9821
Copy link
Contributor

@hawk9821 hawk9821 commented Jan 6, 2025

Purpose of this pull request

Fix avro miss convert short type to int. Avro doesn't support short type value.

2025-01-05T18:43:36.8937934Z Caused by: org.apache.avro.AvroRuntimeException: Unknown datum type java.lang.Short: 12250
2025-01-05T18:43:36.8938460Z 	at org.apache.avro.generic.GenericData.getSchemaName(GenericData.java:933)
2025-01-05T18:43:36.8938960Z 	at org.apache.avro.generic.GenericData.resolveUnion(GenericData.java:892)
2025-01-05T18:43:36.8939503Z 	at org.apache.avro.generic.GenericDatumWriter.resolveUnion(GenericDatumWriter.java:272)
2025-01-05T18:43:36.8940145Z 	at org.apache.avro.generic.GenericDatumWriter.writeWithoutConversion(GenericDatumWriter.java:143)
2025-01-05T18:43:36.8940748Z 	at org.apache.avro.generic.GenericDatumWriter.write(GenericDatumWriter.java:83)
2025-01-05T18:43:36.8941299Z 	at org.apache.avro.generic.GenericDatumWriter.writeField(GenericDatumWriter.java:221)
2025-01-05T18:43:36.8942113Z 	at org.apache.avro.generic.GenericDatumWriter.writeRecord(GenericDatumWriter.java:210)
2025-01-05T18:43:36.8942758Z 	at org.apache.avro.generic.GenericDatumWriter.writeWithoutConversion(GenericDatumWriter.java:131)
2025-01-05T18:43:36.8943358Z 	at org.apache.avro.generic.GenericDatumWriter.write(GenericDatumWriter.java:83)
2025-01-05T18:43:36.8943877Z 	at org.apache.avro.generic.GenericDatumWriter.write(GenericDatumWriter.java:73)
2025-01-05T18:43:36.8944506Z 	at org.apache.seatunnel.format.avro.AvroSerializationSchema.serialize(AvroSerializationSchema.java:55)
2025-01-05T18:43:36.8945466Z 	at org.apache.seatunnel.connectors.seatunnel.kafka.serialize.DefaultSeaTunnelRowSerializer.lambda$valueExtractor$9(DefaultSeaTunnelRowSerializer.java:198)
2025-01-05T18:43:36.8946607Z 	at org.apache.seatunnel.connectors.seatunnel.kafka.serialize.DefaultSeaTunnelRowSerializer.serializeRow(DefaultSeaTunnelRowSerializer.java:70)
2025-01-05T18:43:36.8947533Z 	at org.apache.seatunnel.connectors.seatunnel.kafka.sink.KafkaSinkWriter.write(KafkaSinkWriter.java:114)
2025-01-05T18:43:36.8948350Z 	at org.apache.seatunnel.connectors.seatunnel.kafka.sink.KafkaSinkWriter.write(KafkaSinkWriter.java:59)
2025-01-05T18:43:36.8949142Z 	at org.apache.seatunnel.translation.spark.sink.write.SeaTunnelSparkDataWriter.write(SeaTunnelSparkDataWriter.java:69)
2025-01-05T18:43:36.8950009Z 	at org.apache.seatunnel.translation.spark.sink.write.SeaTunnelSparkDataWriter.write(SeaTunnelSparkDataWriter.java:40)
2025-01-05T18:43:36.8950857Z 	at org.apache.spark.sql.execution.datasources.v2.DataWritingSparkTask$.$anonfun$run$1(WriteToDataSourceV2Exec.scala:442)
2025-01-05T18:43:36.8951545Z 	at org.apache.spark.util.Utils$.tryWithSafeFinallyAndFailureCallbacks(Utils.scala:1538)
2025-01-05T18:43:36.8952374Z 	at org.apache.spark.sql.execution.datasources.v2.DataWritingSparkTask$.run(WriteToDataSourceV2Exec.scala:480)
2025-01-05T18:43:36.8953176Z 	at org.apache.spark.sql.execution.datasources.v2.V2TableWriteExec.$anonfun$writeWithV2$2(WriteToDataSourceV2Exec.scala:381)
2025-01-05T18:43:36.8953830Z 	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
2025-01-05T18:43:36.8954246Z 	at org.apache.spark.scheduler.Task.run(Task.scala:136)
2025-01-05T18:43:36.8954681Z 	at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:548)
2025-01-05T18:43:36.8955151Z 	at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1504)
2025-01-05T18:43:36.8955663Z 	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:551)
2025-01-05T18:43:36.8956228Z 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
2025-01-05T18:43:36.8956781Z 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
2025-01-05T18:43:36.8957194Z 	at java.lang.Thread.run(Thread.java:750)

Does this PR introduce any user-facing change?

no

How was this patch tested?

modify AvroConverterTest and AvroSerializationSchemaTest

Check list

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passes. Thanks @hawk9821 !

@wuchunfu wuchunfu merged commit d72b3c8 into apache:dev Jan 6, 2025
5 checks passed
@hawk9821 hawk9821 deleted the avro_short_bug branch January 6, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants