Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Zeta] Make sure the local mode CompletableFuture behavior same as server mode #8476

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Jan 8, 2025

Purpose of this pull request

Make sure the local mode CompletableFuture behavior same as server mode, we should set our own EXECUTOR to hazelcast same as server mode in https://github.com/apache/seatunnel/blob/dev/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServerStarter.java#L59

Does this PR introduce any user-facing change?

no

How was this patch tested?

exist test.

Check list

@github-actions github-actions bot added the core SeaTunnel core module label Jan 8, 2025
hailin0
hailin0 previously approved these changes Jan 8, 2025
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Hisoka-X Hisoka-X merged commit 39d7a40 into apache:dev Jan 9, 2025
2 of 3 checks passed
@Hisoka-X Hisoka-X deleted the complete-future-update branch January 13, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved core SeaTunnel core module reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants