Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-446] Add floating point datatype support in RS_AsBase64 #1146

Merged
merged 9 commits into from
Dec 16, 2023

Conversation

furqaankhan
Copy link
Contributor

@furqaankhan furqaankhan commented Dec 13, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

How was this patch tested?

  • passed existing tests

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation update.

Copy link
Member

@jiayuasu jiayuasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case?

@jiayuasu
Copy link
Member

jiayuasu commented Dec 14, 2023

@furqaankhan Please fix the failed test. Make sure you use real float numbers in the test, not integers.

Co-authored-by: John Bampton <jbampton@users.noreply.github.com>
@jiayuasu jiayuasu merged commit eb3c499 into apache:master Dec 16, 2023
40 checks passed
@furqaankhan furqaankhan deleted the rs-base64-feat branch July 16, 2024 01:38
Kontinuation pushed a commit to Kontinuation/sedona that referenced this pull request Oct 11, 2024
…he#1146)

Co-authored-by: John Bampton <jbampton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RS_AsBase64 returns empty string
3 participants