-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Docker build improvements #1425
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kontinuation
force-pushed
the
improve-docker-build
branch
from
May 24, 2024 02:54
4c882c1
to
a532c7e
Compare
Kontinuation
force-pushed
the
improve-docker-build
branch
2 times, most recently
from
May 24, 2024 03:09
896e911
to
69863bc
Compare
Kontinuation
force-pushed
the
improve-docker-build
branch
2 times, most recently
from
May 24, 2024 03:28
255bdad
to
02992e0
Compare
Kontinuation
force-pushed
the
improve-docker-build
branch
from
May 24, 2024 03:29
02992e0
to
71c56ba
Compare
…ns before launching
Kontinuation
force-pushed
the
improve-docker-build
branch
from
May 24, 2024 04:15
e336c21
to
ed36964
Compare
jiayuasu
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Kontinuation
added a commit
to Kontinuation/sedona
that referenced
this pull request
Oct 11, 2024
* Improve docker file * Make it work for both latest version and released version * Fix build for macos * Fix buildx for macos * Install docker-buildx for macos-12 * Change matrix definition for docker build * Check total physical memory and DRIVER_MEM, EXECUTOR_MEM configurations before launching * Fix gresearch spark-extension version and improved code for detecting spark versions * Use array form of CMD to allow control signals to be passed to jupyter lab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[CI] my subject
.What changes were proposed in this PR?
SPARK_WORKER_MEMORY
config to ensure the worker has enough memory to be allocatedHow was this patch tested?
Tested locally and passing CI.
Did this PR include necessary documentation updates?