Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-651] Add spark prefix to all sedona spark config #1580

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

jiayuasu
Copy link
Member

@jiayuasu jiayuasu commented Sep 5, 2024

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Add the spark prefix to all existing configs and allow them to co-exist in the config.

Users can set via both methods sedona. or spark.sedona. but when both options present, the parameter set through sedona prefix will override the parameter set through spark.sedona prefix.

How was this patch tested?

Passed existing tests

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation.

Copy link
Member

@Kontinuation Kontinuation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiayuasu jiayuasu merged commit 5e64c84 into master Sep 5, 2024
51 checks passed
Kontinuation pushed a commit to Kontinuation/sedona that referenced this pull request Oct 11, 2024
apache#281)

* [SEDONA-651] Add spark prefix to all sedona spark config (apache#1580)

* Fix the doc and style
@jiayuasu jiayuasu deleted the SEDONA-651 branch November 4, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants